Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Miscellaneous comment fixes / updates #824

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: Miscellaneous comment fixes / updates #824

merged 2 commits into from
Sep 17, 2024

Conversation

sichanyoo
Copy link
Contributor

Issue #

Description of changes

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jbelkins
jbelkins approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge after 1.0.0 ships.

@sichanyoo sichanyoo merged commit 6c122dc into main Sep 17, 2024
27 checks passed
@sichanyoo sichanyoo deleted the chore/comment-fixes branch September 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelkins jbelkins jbelkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sichanyoo @jbelkins